Merged
Conversation
Contributor
Author
|
@mnyrop I'm reasonably sure these changes are merely syntactical, but I do think we should QA it to make sure I didn't, in fact, introduce any bugs. Do we do that? If so, how? |
Member
|
@the-codetrane after we merge #266 we can fold this in and add linting as a step to the CI. Then when these commits pass existing tests 🤞🏻 that'll be confirmation enough to keep sprinting |
the-codetrane
force-pushed
the
add-rubocop
branch
from
66a20c9 to
14d7121
Compare
Member
|
@the-codetrane ci tests pass, rubocop (as current configured in the rubocop.yml) fails. I'll leave it up to you if you'd like to make rubocop pass before merging this PR? Or if you'd rather temporarily re-disable its invocation in the workflow yaml while you power through other tickets–that's fine too. Either way, approving this PR now! |
mnyrop
approved these changes
Jun 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding linting to the app to unify coding style and sanitize code base.